Refactor interop to use CsWin32/LibraryImport #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Luu <[email protected]>
There was a problem hiding this comment.
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (2)
- FluentAutoClicker/FluentAutoClicker.csproj: Language not supported
- FluentAutoClicker/NativeMethods.txt: Language not supported
Comments suppressed due to low confidence (1)
FluentAutoClicker/MainPage.xaml.cs:42
- The 'wndProc' field is initialized to 'null!' and then assigned later. This could lead to a null reference issue if 'HotKeyProc' is called before 'MainPage_Loaded'. Initialize 'wndProc' properly.
private WNDPROC wndProc = null!;
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
There was a problem hiding this comment.
Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (3)
- FluentAutoClicker/FluentAutoClicker.csproj: Language not supported
- FluentAutoClicker/MainPage.xaml: Language not supported
- FluentAutoClicker/NativeMethods.txt: Language not supported
Comments suppressed due to low confidence (1)
FluentAutoClicker/Program.cs:74
- The lpName parameter is nullable. Ensure that the nullability is handled correctly, either by adding a null check or handling the nullability explicitly.
string? lpName);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modernizes interop to replace
DllImportwithLibraryImportorPInvokewith CsWin32 when possible. The goal of this PR is to improve project readability by reducing complexity. This paves the path for being able to add bindable hotkeys in the future.They are some trade-offs in this PR as it adds CsWin32 as a dependency and CsWin32 still uses DllImport instead of LibraryImport which may pose some AOT issues.
Related Issues
Changes Made
Code Modernization:
FluentAutoClicker/App.xaml.cs: Replaced the staticWindowproperty withMainWindowand updated theOnLaunchedmethod to activateMainWindowdirectly. [1] [2]FluentAutoClicker/Helpers/AutoClicker.cs: Converted P/Invoke declarations to use source-generated interop withLibraryImport.FluentAutoClicker/Program.cs: Updated P/Invoke declarations to use source-generated interop withLibraryImport.Dependency Updates:
FluentAutoClicker/FluentAutoClicker.csproj: Enabled unsafe blocks and added a package reference forMicrosoft.Windows.CsWin32. [1] [2]Code Cleanup:
FluentAutoClicker/Helpers/WindowMessageHook.cs: Removed theWindowMessageHookclass and related interop code as it is no longer needed.Hotkey Handling:
FluentAutoClicker/MainPage.xaml.cs: Refactored hotkey handling to use Windows API directly and removed the old interop code. [1] [2]Native Methods:
FluentAutoClicker/NativeMethods.txt: Added new native methods used in the updated hotkey handling.Checklist
LibraryImportSendInputinAutoClicker.csto reduce lines of codeAdditional Notes